Conversation
WizFizz
left a comment
There was a problem hiding this comment.
Thanks for the suggestion, and for taking the time to include a test with it.
The change itself looks reasonable, but I don't think we're going to take this one. Since AcceptedHonorDuel is still being added upstream, whatever ships as 0.11.6 won't match this revision, so we'd be replacing the pin shortly after merging it and I'd rather not carry an off-registry dependency in the parser for the few days in between. Feels cleaner to just wait for the release.
Appreciated regardless, and it's good to know the upstream fix is close!
|
No worries, will leave this open for now in case things don't progress as expected in the upstream PR, just considering the MLE draft deadline is approaching and a lot of people haven't met their scrim requirements |
Not sure it's worth it at this point, but here's a suggestion for a temporary fix to get scrims restored this weekend in case things drag on with boxcars.
Given that the main required fixes seem to be implemented and they are just debating on the test suite and possibly honor duels and camera settings, which shouldn't impact sprocket, we could just point at the git revision with the fix for now and switch to the new build later when it's available.
Includes new test with a s24 replay, taken from boxcars.