Skip to content

Temporary boxcars fix - #12

Closed
SPD-13 wants to merge 4 commits into
SprocketBot:mainfrom
SPD-13:fix/temp-boxcars-fix
Closed

SPD-13 wants to merge 4 commits into
SprocketBot:mainfrom
SPD-13:fix/temp-boxcars-fix

Conversation

@SPD-13

@SPD-13 SPD-13 commented Sep 26, 2026 •

Copy link
Copy Markdown

Not sure it's worth it at this point, but here's a suggestion for a temporary fix to get scrims restored this weekend in case things drag on with boxcars.
Given that the main required fixes seem to be implemented and they are just debating on the test suite and possibly honor duels and camera settings, which shouldn't impact sprocket, we could just point at the git revision with the fix for now and switch to the new build later when it's available.
Includes new test with a s24 replay, taken from boxcars.

@WizFizz WizFizz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, and for taking the time to include a test with it.

The change itself looks reasonable, but I don't think we're going to take this one. Since AcceptedHonorDuel is still being added upstream, whatever ships as 0.11.6 won't match this revision, so we'd be replacing the pin shortly after merging it and I'd rather not carry an off-registry dependency in the parser for the few days in between. Feels cleaner to just wait for the release.

Appreciated regardless, and it's good to know the upstream fix is close!

@SPD-13

SPD-13 commented Sep 27, 2026

Copy link
Copy Markdown
Author

No worries, will leave this open for now in case things don't progress as expected in the upstream PR, just considering the MLE draft deadline is approaching and a lot of people haven't met their scrim requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants