Repository navigation
Treat exam centre valid_till as last confirmed administration - #340
Merged
Merged
Conversation
SAT and foreign language exam centres: an expired valid_till now shows "Last confirmed for <date>" in a neutral tone, and the freshness check warns instead of failing. Other places and competitions stay strict. Refs #339
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339
Option 2 from the issue.
valid_tillnow means the last administration the centre was confirmed for. The pin pill reads "Last confirmed for " in a neutral tone instead of "Expired".npm run check:freshnesswarns once per file for passed exam centre dates instead of failing. Other places and all competitions keep the strict check. 707 errors drop to 0; the remaining 30 are competition records (Data freshness check failed #276).exam-dates.ts; its test was failing on main because the date has passed. No December date added, I could not verify it.Not touched: the 707 dates themselves. Nobody has re-confirmed the venues for the next administration, so they stay at 2026-11-07.