Skip to content

chore: improve funcy maintenance path - #166

Closed
lphuc2250gma wants to merge 1 commit into
Suor:masterfrom
lphuc2250gma:maint/20260525162741
Closed

chore: improve funcy maintenance path#166
lphuc2250gma wants to merge 1 commit into
Suor:masterfrom
lphuc2250gma:maint/20260525162741

Conversation

@lphuc2250gma

Copy link
Copy Markdown

Summary:

  • Add edge-case unit tests in tests/test_strings.py covering empty-string and non-matching inputs for cut_prefix/cut_suffix and str_join (e.g., cut_prefix('', 'x'), cut_suffix('abc', 'abc'), str_join('-', []) returning correct empty/identity values). Pure additive tests; no production code changes required.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@Suor

Suor commented May 27, 2026

Copy link
Copy Markdown
Owner

Tests are code, adding code is a bad thing. We do it when it's necessary. These tests are probably not it, i.e. we did fine without for quite a while and those functions aren't really hot anyway.

@Suor Suor closed this May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants