Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
clawbench-reproduce --work-dir <existing-directory>previously deleted the entire supplied directory after comparison, including unrelated user files. Downloads now go into a unique invocation-owned child directory. Only that child is removed when the invocation finishes or unwinds;--keep-cacheretains it and prints its exact path.Temporary-directory cleanup covers PASS, FAIL, download errors, judge errors and interruption. Independent child directories prevent one invocation from deleting another invocation's cache. The caller's parent directory and pre-existing contents are preserved. Includes the required Unreleased changelog entry.
Corpus
Host-side reproduction CLI cleanup only.
Test plan
--keep-cache, plus overlapping cache lifetimes. Each CLI case preserves an unrelated sentinel and a previous cache.uv run --frozen pytest -q— 294 passed, 3 skipped.uv run --frozen pyright— 0 errors.git diff --check.uv build— wheel and sdist successfully built.Download and judge calls are mocked in the regression tests; no live HF/model run or package publication was performed. Reproduction metric validation and judge-cache correctness remain separate issues #362–#364. Retained downloads now live one unique directory below
--work-dir, so callers inspecting the old direct layout should use the printed cache path.Related issues
Fixes #361. Part of the next-release quality checklist #366.
@Perry2004 please review the cache ownership/cleanup behavior and prioritize this data-loss fix for the next release.