Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A change to
runtime-server/server.pyor its dependencies triggered the harness-build workflow but selected zero downstream harness images: the inline Bash selector still matched the obsoleteextension-server/directory. Extract dependency selection intoscripts/ci/select_harness_builds.pyand select all native harnesses for shared runtime-server, base, recorder, shared-data and registry changes.Single-harness changes select only that harness. Deleted dependency paths participate in the diff; rename detection is disabled so moves across harnesses include both source and destination. Manual and workflow/selector-only runs exercise the full matrix. Harbor-only changes retain an empty native matrix, and the base image is still built by its separate job.
The workflow keeps Git revision validation and passes changed paths as NUL-delimited data. The helper owns matrix/count output and the readable summary. Both build and host-test workflows now trigger on selector changes. Includes the required Unreleased changelog entry.
Corpus
Native harness CI dependency selection only.
Test plan
uv run --frozen pytest -q— 300 passed, 3 skipped.git diff --check.No Docker image was built locally; this verifies build-plan selection and workflow plumbing. Shared runtime changes will intentionally schedule more downstream builds, closing the existing coverage gap.
Related issues
Fixes #365. Part of next-release quality checklist #366. Does not reopen deferred Harbor CI #350.
@Perry2004 please review shared-dependency coverage, scoped build behavior and the extracted selector contract.