Repository navigation
fix(ocf): default missing avro.codec to null - #44
Merged
Merged
Conversation
Owner
|
I'm not fond of the new public Default impl, but agree this should be fixed in the Deserialize impl. |
Owner
|
Oh wait that is private anyway. OK then my only question is can't we derive default instead of implementing it manually? |
Contributor
Author
|
Ah, I missed that. Yeah, deriving |
Owner
|
released as 2.1.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the Apache Avro specification, the
avro.codecmetadata entry is optional. When it is absent, readers should treat the codec asnull.The current OCF metadata implementation requires
avro.codecto be present:As a result, valid Avro Object Container Files that omit
avro.codecfail to deserialize with a missing-field error.This PR changes
CompressionCodecto default toCompressionCodec::Nulland marks thecodecfield with#[serde(default)].