Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #243.
Problem
bsk session startalways opens a dedicated Agent Window. In single-window and Arc workflows, this creates an extra window when the user wants the session's tabs in their current window.Changes
bsk session start --in-window. It creates a session tab in the last-focused normal, non-incognito user window without creating another window.Scope and safety
This is an opt-in local-session mode. Ordinary sessions and
record startretain their dedicated-window behavior. Remote sessions and window dimensions are unsupported with--in-window. Tab grouping is not included.Validation
The final commit was locally tested before the force-push. Regression tests cover shared-window startup, tab ownership, same-window borrow and return, tab closure, and a tab moved during CDP setup.
Arc and macOS live-browser testing was not performed.