Skip to content

fix: add --locked to uv export in Dockerfile - #1046

Merged
TomerFi merged 1 commit into
devfrom
fix/dockerfile-uv-locked
Aug 12, 2026
Merged

fix: add --locked to uv export in Dockerfile#1046
TomerFi merged 1 commit into
devfrom
fix/dockerfile-uv-locked

Conversation

@TomerFi

@TomerFi TomerFi commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Adds --locked to uv export in the Dockerfile so it reads directly from uv.lock (~0.95ms) instead of re-resolving dependencies on every build.

This keeps the deterministic install from PR #1044 while avoiding the slow resolution step during container builds.

Summary by CodeRabbit

  • Bug Fixes
    • Improved container builds by ensuring dependencies are installed from the locked versions.

@snyk-io

snyk-io Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Test Results

69 tests   69 ✅  1s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit cc0bf8b.

♻️ This comment has been updated with latest results.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

Docker build setup

Layer / File(s) Summary
Dependency installation and source copy
Dockerfile
The Dockerfile copies dependency metadata before installing dependencies, uses --locked for dependency export, and copies app/webapp.py separately afterwards.

Suggested reviewers: dmatik

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: adding --locked to uv export in the Dockerfile.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dockerfile-uv-locked

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.07%. Comparing base (130e428) to head (cc0bf8b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1046   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files           1        1           
  Lines         331      331           
=======================================
  Hits          318      318           
  Misses         13       13           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TomerFi
TomerFi force-pushed the fix/dockerfile-uv-locked branch from 2c4f4f1 to cc0bf8b Compare August 12, 2026 14:51

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile`:
- Line 13: Update the Dockerfile’s uv installation step to use an explicitly
approved, pinned uv version rather than the unversioned package; verify that the
selected version supports Python 3.14.5 and every target platform, and prefer a
pinned uv image tag or digest where applicable.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 892a194b-c74d-4c52-8e7d-88e2d1f510ee

📥 Commits

Reviewing files that changed from the base of the PR and between 130e428 and 2c4f4f1.

📒 Files selected for processing (1)
  • Dockerfile

Comment thread Dockerfile
@TomerFi
TomerFi merged commit 30da370 into dev Aug 12, 2026
10 checks passed
@TomerFi
TomerFi deleted the fix/dockerfile-uv-locked branch August 12, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant