fix: include uv.lock in release workflow commits - #1047
Conversation
…are preserved - uv version --bump updates both pyproject.toml and uv.lock - the first commit only added pyproject.toml and mkdocs.yml - the second commit only added pyproject.toml - lockfile changes were being discarded, causing pages workflow to fail on release tags - both commits now include uv.lock
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the release GitHub Actions workflow so that uv.lock is committed alongside pyproject.toml (and mkdocs.yml where applicable), ensuring the lockfile version stays in sync with the project version during release and post-release dev bumps. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Test Results69 tests 69 ✅ 1s ⏱️ Results for commit 518b296. ♻️ This comment has been updated with latest results. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe release workflow now stages ChangesRelease workflow
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1047 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 1 1
Lines 331 331
=======================================
Hits 318 318
Misses 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Problem
The pages workflow (GH-Pages deploy) fails on release tags with:
Root cause
uv version --bumpupdates bothpyproject.tomlanduv.lock— uv bakes the project version into the lockfile. However, the release workflow only committedpyproject.tomlandmkdocs.yml, discarding the lockfile update. The release tag therefore has a stale lockfile that doesn't match pyproject.toml.Fix
Add
uv.lockto bothgit addcommands in the release workflow:pyproject.toml→mkdocs.yml→uv.lockpyproject.toml→uv.lockSummary by CodeRabbit