Repository navigation
enhance(calls): 終了した通話の開始・終了日時と合計時間を表示 - #69
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (16 updated, 0 added, 0 removed)
Startup chunk size (1 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
終了したCallsのルーム画面と共有リンクカードに、開始日時・終了日時・ルーム全体の通話時間を表示します。終了時にルーム画面を残し、後から同じリンクで開き直せます。
終了イベントを受けたら既存の
calls/rooms/showから確定した時刻を取得します。古い応答で状態が戻らないようにし、日時の欠落・不正値は「不明」と表示します。24時間を超える通話にも対応します。Why
元の要望に対応し、通話が何時から何時まで続いたかを終了後に確認できるようにします。
関連: #17。既存の #50 の個人の参加時間タイマーと #48 のルーム情報更新を参考にしています。参加中の個人タイマーは変更していません。
Additional info (optional)
DB・API・閲覧権限の変更はありません。履歴一覧や個人の参加時間の累積は今回の対象外です。
検証:
6cb44f4のGitHub CIは実行された25チェックすべて成功。frontend unit/E2E、全lint/型検査、本番ビルド、locale、SPDX、frontend diagnostics、Dockleを含みます。Storybookはdraft条件でスキップされました。pnpm exec node --import tsx ./build.ts)。node scripts/check-shipping.mjs --base 2bb19b9(変更ファイルlint、SPDX、locale safety)、git diff --check。calls-session.test.tsのbeforeunload型比較エラー2件は、テストのspy対象をDOMのEventTargetと明示する最小修正で解消しました。テストの検証内容と本番コードは変更していません。CHANGELOGはリポジトリ方針に従い未編集です。候補:
Enhance: 終了したCallsに開始・終了日時とルーム全体の通話時間を表示Checklist