Skip to content

fix(calls): 設定を右端の歯車から一般タブで開く - #80

Merged
mattyatea merged 1 commit into
developfrom
codex/calls-settings-general
Oct 7, 2026
Merged

mattyatea merged 1 commit into
developfrom
codex/calls-settings-general

Conversation

@mattyatea

Copy link
Copy Markdown
Contributor

What

通話ウィンドウと Dock の設定ボタンを、退出ボタンの右にある歯車に変更し、「一般」を開くようにします。ノイズキャンセル方式・自動音量調整・送信開始のしきい値は既存の設定を利用します。

通常表示のリアルタイム音量メーターと dBFS の現在値を外し、dBFS は選択したしきい値だけ表示します。マイクテスト中は音量メーターと送信状態を表示し、統計表示も引き続き選択できます。

右端の設定ボタン
一般の設定画面

スマートフォン幅(390px)

スマートフォン幅の設定画面

Why

設定を右端の歯車から開き、最初に一般設定を表示したいという要望に対応します。現在の音量と、ユーザーが設定した送信しきい値を混同しないようにします。

Related: #17

Additional info (optional)

  • PASS: 音声設定・マイクテスト・Dock・ウィンドウの unit test 14件。
  • PASS: frontend の vue-tsc --noEmit、node scripts/check-shipping.mjs --base origin/develop(変更ファイル lint / SPDX / locale safety)、git diff --check。
  • ブラウザーで歯車→一般、方式切り替え、自動音量調整、しきい値変更、390px 幅を確認。スクショは実コンポーネントのプレビューで、デバイス・通話状態は固定データです。実通話は未検証です。
  • 検証は既存依存を共有した独立 worktree で実施。テストの fs.allow と型チェックの生成物パスだけ一時設定で調整しました。
  • CHANGELOG はリポジトリ方針に従い未編集。候補: 通話設定を右端の歯車から一般タブで開き、送信しきい値の数値表示を固定する。

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

Copilot AI balanced review requested due to automatic review settings October 6, 2026 16:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: Type4ny-Project/Misskey/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 30acc5ad-11d4-4912-b2a8-32bc21e58509
📥 Commits

Reviewing files that changed from the base of the PR and between 62d7367 and d5daf25.

⛔ Files ignored due to path filters (3)
  • docs/screenshots/calls-settings-controls.png is excluded by !**/*.png
  • docs/screenshots/calls-settings-general-mobile.png is excluded by !**/*.png
  • docs/screenshots/calls-settings-general.png is excluded by !**/*.png
📒 Files selected for processing (7)
  • packages/frontend/src/components/MkCallsControls.vue
  • packages/frontend/src/components/MkCallsMicrophoneTest.vue
  • packages/frontend/src/components/MkCallsRoomWindow.vue
  • packages/frontend/src/components/MkCallsSettings.vue
  • packages/frontend/src/ui/_common_/CallsDock.vue
  • packages/frontend/test/unit/calls-audio-settings.test.ts
  • packages/frontend/test/unit/calls-microphone-test.test.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

🖥 Frontend Diagnostics Report

(No significant changes)

View details

Requests by resource type
Type Requests Encoded bytes
Base Head Δ Base Head Δ
Document 2 2 0 34 KB 34 KB 0 B
Script 152 152 0 2.4 MB 2.4 MB $\color{orange}{\text{+2 B}}$
Stylesheet 63 63 0 320 KB 320 KB $\color{green}{\text{-80 B}}$
Fetch 28 28 0 47 KB 47 KB 0 B
Image 9 9 0 238 KB 238 KB 0 B
Font 2 2 0 129 KB 129 KB $\color{green}{\text{-728 B}}$
Other 9 9 0 421 KB 421 KB $\color{orange}{\text{+17 B}}$
V8 heap snapshot statistics
Metric @ Base @ Head Δ MAD
$\color{gray}{\rule{8pt}{8pt}}$ Total 12 MB
± 5 KB
12 MB
± 3.3 KB
$\text{-4.3 KB}$
$\text{-0\%}$
6 KB
$\color{orange}{\rule{8pt}{8pt}}$ Code 3 MB 3 MB $\text{+1 KB}$ 2.1 KB
$\color{red}{\rule{8pt}{8pt}}$ Strings 1.3 MB 1.3 MB $\text{-456 B}$ 160 B
$\color{cyan}{\rule{8pt}{8pt}}$ JS arrays 122 KB 122 KB 0 B 0 B
$\color{green}{\rule{8pt}{8pt}}$ Typed arrays 0 B 0 B 0 B 0 B
$\color{yellow}{\rule{8pt}{8pt}}$ System objects 0 B 0 B 0 B 0 B
$\color{violet}{\rule{8pt}{8pt}}$ Other JS objs 2.2 MB 2.2 MB $\text{-168 B}$ 121 B
$\color{pink}{\rule{8pt}{8pt}}$ Other non-JS objs 5.5 MB 5.5 MB $\text{-5.4 KB}$ 5 KB

Download representative heap snapshot: base / head

📦 Bundle Stats

Chunk size diff (3 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 6.1 MB 6.1 MB $\text{-70 B}$ $\text{-0\%}$
(other generated chunks) 2.3 MB 2.3 MB $\text{-61 B}$ $\text{-0\%}$
(other) 46 KB 46 KB $\text{-9 B}$ $\text{-0\%}$
Startup chunk size (0 updated, 0 added, 0 removed)
Chunk Base Head Δ Δ (%)
(total) 956 KB 956 KB 0 B 0%
(other generated chunks) 882 KB 882 KB 0 B 0%
(other) 74 KB 74 KB 0 B 0%

Startup chunks are the Vite entry for src/_boot_.ts and its static imports.

Bundles Modules Entries Imports Size
Static Dynamic Rendered Gzip Brotli
Base 509 3,030 22 11,273 366 11 MB 3 MB 2.6 MB
Head 509 3,030 22 11,273 366 11 MB 3 MB 2.6 MB
Δ 0 0 0 0 0 $\text{-79 B}$ $\text{-36 B}$ $\text{+38 B}$
Δ (%) 0% 0% 0% 0% 0% $\text{-0\%}$ $\text{-0\%}$ $\text{+0\%}$

Open treemap HTML

@mattyatea
mattyatea merged commit 5d23778 into develop Oct 7, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants