Repository navigation
fix(calls): 設定を右端の歯車から一般タブで開く - #80
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
⛔ Files ignored due to path filters (3)
📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🖥 Frontend Diagnostics Report(No significant changes) Requests by resource type
V8 heap snapshot statistics
📦 Bundle StatsChunk size diff (3 updated, 0 added, 0 removed)
Startup chunk size (0 updated, 0 added, 0 removed)
Startup chunks are the Vite entry for
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
通話ウィンドウと Dock の設定ボタンを、退出ボタンの右にある歯車に変更し、「一般」を開くようにします。ノイズキャンセル方式・自動音量調整・送信開始のしきい値は既存の設定を利用します。
通常表示のリアルタイム音量メーターと dBFS の現在値を外し、dBFS は選択したしきい値だけ表示します。マイクテスト中は音量メーターと送信状態を表示し、統計表示も引き続き選択できます。
スマートフォン幅(390px)
Why
設定を右端の歯車から開き、最初に一般設定を表示したいという要望に対応します。現在の音量と、ユーザーが設定した送信しきい値を混同しないようにします。
Related: #17
Additional info (optional)
vue-tsc --noEmit、node scripts/check-shipping.mjs --base origin/develop(変更ファイル lint / SPDX / locale safety)、git diff --check。Checklist