Skip to content

fix: add dependency cases for a parent that is off by its strategy #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwasniew merged 3 commits into from
Sep 29, 2026
Merged

fix: add dependency cases for a parent that is off by its strategy #138

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e40ec3c
fix: add dependency cases for a parent that is off by its strategy
kwasniew Sep 29, 2026
86b87bc
test: add missing test cases
kwasniew Sep 29, 2026
fea7aa0
test: remove a case that repeats an existing rule
kwasniew Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 98 additions & 0 deletions specifications/17-dependent-features.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,60 @@
},
"variants": []
}]
},
{
"name": "parent.with.constraint.child.expects.disabled",
"description": "The parent is enabled and has a constraint. The child expects the parent to be disabled.",
"enabled": true,
"dependencies": [{
"feature": "parent.with.constraint",
"enabled": false
}],
"strategies": [{
"name": "flexibleRollout",
"parameters": {
"rollout": "100",
"stickiness": "default",
"groupId": "groupId"
},
"variants": [
{
"name": "child.variant",
"weight": 1,
"payload": {
"type": "string",
"value": "variantValue"
}
}
]
}]
},
{
"name": "parent.with.constraint.child.expects.disabled.variant",
"description": "The parent is enabled and has a constraint. The child expects the parent's variant to be \"disabled\".",
"enabled": true,
"dependencies": [{
"feature": "parent.with.constraint",
"variants": ["disabled"]
}],
"strategies": [{
"name": "flexibleRollout",
"parameters": {
"rollout": "100",
"stickiness": "default",
"groupId": "groupId"
},
"variants": [
{
"name": "child.variant",
"weight": 1,
"payload": {
"type": "string",
"value": "variantValue"
}
}
]
}]
}
]
},
Expand Down Expand Up @@ -780,6 +834,22 @@
"context": {},
"toggleName": "parent.disabled.child.expects.disabled.variant",
"expectedResult": false
},
{
"description": "Child is enabled if the parent is expected to be disabled and the parent's constraint does not match.",
"context": {
"environment": "dev"
},
"toggleName": "parent.with.constraint.child.expects.disabled",
"expectedResult": true
},
{
"description": "Child is disabled when it requires the parent's variant to be \"disabled\" and the parent is off because its constraint does not match.",
"context": {
"environment": "dev"
},
"toggleName": "parent.with.constraint.child.expects.disabled.variant",
"expectedResult": false
}
],
"variantTests": [
Expand Down Expand Up @@ -1012,6 +1082,34 @@
"enabled": true,
"feature_enabled": true
}
},
{
"description": "Child yields its variant when the parent is expected to be disabled and the parent's constraint does not match.",
"context": {
"environment": "dev"
},
"toggleName": "parent.with.constraint.child.expects.disabled",
"expectedResult": {
"name": "child.variant",
"payload": {
"type": "string",
"value": "variantValue"
},
"enabled": true,
"feature_enabled": true
}
},
{
"description": "Child yields a disabled variant when it requires the parent's variant to be \"disabled\" and the parent is off because its constraint does not match.",
"context": {
"environment": "dev"
},
"toggleName": "parent.with.constraint.child.expects.disabled.variant",
"expectedResult": {
"name": "disabled",
"enabled": false,
"feature_enabled": false
}
}
]
}
Loading