upipe_xfer: use ueventfd to suspend remote thread - #1227
Open
nto wants to merge 2 commits into
Open
Conversation
Also fix the fallback eventfd init which contained invalid code for setting non-blocking mode.
Using a mutex for blocking a remote event loop may introduce unbounded wait because pthread_mutex_unlock does not guarantee that another thread waiting to acquire the lock will be scheduled right away. Instead, use a pair of ueventfd for synchronization, and add a UPIPE_XFER_YIELD message to ask the remote thread to suspend itself. Moreover, mutex based exclusion was generally impossible to implement in upump managers other than libev.
nto
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersede #1218.