Repository navigation
Pin selectolax to 0.4.x to fix missing images - #652
Merged
Merged
Conversation
selectolax 1.0.1 causes mkdocs-glightbox to strip <img> tags from the built pages, so images no longer appear on docs.v1e.com. 0.4.13 builds correctly.
Owner
|
Thank you!!! We need to move off mkdocs real soon, I am not looking forward to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Images are no longer showing on docs.v1e.com because the built pages are missing their
<img>tags. The image files themselves are still deployed.Cause
mkdocs-glightbox requires
selectolax>=0.3.29with no upper bound. The last working deploy installed selectolax 1.0.0. The most recent deploy picked up the new 1.0.1 release, and with that version glightbox strips the<img>tags out of every page during the build.Fix
Pin
selectolax~=0.4.13inrequirements.txt. This stays on the 0.4.x line, which predates the new 1.x releases, and still allows 0.4.x patch updates.Testing
Local
mkdocs build, counting<img>tags inlowrider/index.html:<img>tagsOnce glightbox or selectolax ships a fix for 1.x, the pin can be removed.