Skip to content

Add MiniMax target model to router types - #1391

Open
octo-patch wants to merge 1 commit into
VoltAgent:mainfrom
octo-patch:octo/20260801-model-add-recvqtBnXA0nzu
Open

Add MiniMax target model to router types#1391
octo-patch wants to merge 1 commit into
VoltAgent:mainfrom
octo-patch:octo/20260801-model-add-recvqtBnXA0nzu

Conversation

@octo-patch

@octo-patch octo-patch commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Reason: Add the current MiniMax model to the model router type map.

Changes:

  • Adds a generator-level model override so regenerated router types retain the MiniMax target model.
  • Updates the generated provider model type map for both MiniMax regional provider IDs.

Checks:

  • node --check packages/core/scripts/generate-model-provider-registry.js
  • git diff --check

Note: The focused package test could not be run because this clone's PNPM install did not create workspace links for test binaries.


Summary by cubic

Adds MiniMax-M2.7 to the model router types and generation so minimax and minimax-cn include the current target model. Ensures routing and types stay in sync across regenerations.

  • Bug Fixes
    • Added a generator-level override to always include MiniMax-M2.7 for minimax and minimax-cn.
    • Updated the generated ProviderModelsMap to list MiniMax-M2.7 for both providers.

Written for commit f4802df. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes
    • Added support for the MiniMax-M2.7 model in MiniMax provider model lists.
    • Ensured model lists are consistently merged, deduplicated, and sorted.

@changeset-bot

changeset-bot Bot commented Aug 2, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f4802df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6fd4e7f6-a8ef-4666-a534-3ed08a46b54e

📥 Commits

Reviewing files that changed from the base of the PR and between 3377f6d and f4802df.

⛔ Files ignored due to path filters (1)
  • packages/core/src/registries/model-provider-types.generated.ts is excluded by !**/*.generated.*
📒 Files selected for processing (1)
  • packages/core/scripts/generate-model-provider-registry.js

📝 Walkthrough

Walkthrough

The provider registry now adds MiniMax-M2.7 for minimax and minimax-cn. It merges these overrides with fetched models, then normalizes, deduplicates, and sorts each provider model list.

Changes

MiniMax provider registry

Layer / File(s) Summary
Static overrides and model list normalization
packages/core/scripts/generate-model-provider-registry.js
The registry adds MiniMax-M2.7 overrides for minimax and minimax-cn. Generated model lists merge the overrides, normalize identifiers, remove duplicates, and sort models.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding the MiniMax target model to router types.
Description check ✅ Passed The description explains the change, affected providers, validation checks, and the reason the focused test was not run.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant