Repository navigation
feat(taxonomy): add opt-in DataForm editor - #546
Open
faisalahammad wants to merge 2 commits into
Open
faisalahammad wants to merge 2 commits into
faisalahammad wants to merge 2 commits into
Conversation
Adds a beta feature that replaces the Basic Settings fields on the taxonomy editor screen with a DataForm driven form. The classic markup stays in the page and is hidden only after the script mounts, so the existing fields still submit and the screen keeps working if the script fails to load. The editor is opt-in through the existing Beta Features page and only loads on WordPress 7.0 and above, where the DataForm components are available. Saving still goes through the current nonce, capability and validation path, so no new persistence route is introduced. This is the first slice of WordPress#156 and covers taxonomies only. Field groups, post types and options pages are follow-ups. See WordPress#156.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
- Handle View and Preview buttons in the shared editor fixture - Match the renamed WP trunk preview menu item Errors fixed: - WP trunk preview timeout in openPreviewPage Refs WordPress#546
Author
CI Fix SummaryUpdated
Validation: lint, Prettier, and diff checks passed. CodeRabbit was unavailable because the review limit was exhausted and no organization seat is assigned. Commit: |
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in beta feature that renders the taxonomy editor Basic Settings with DataForm instead of the classic PHP fields. This is the first slice of #156 and covers taxonomies only, as the issue suggests. Field groups, post types and options pages are follow-ups.
The classic Basic Settings markup stays in the page and is hidden only after the editor mounts. That keeps the Post Types selector, the Advanced Configuration toggle, the taxonomy key slugification and any
acf/taxonomy/basic_settingsadditions working, and it means a script failure leaves the original fields usable. Saving is untouched: the existing nonce, capability check, AJAX key validation andacf_update_internal_post_type()are still the only write path.The editor uses
@wordpress/dataviewsand is limited to WordPress 7.0 and above, where the package is available. Note that #142 mentioned@automattic/dataviewsback in May 2025, while the current WordPress docs use@wordpress/dataviews. Happy to switch if the listing work in #142 lands on the other package.How to test:
Two things worth knowing before review: the taxonomy key slugifies on blur of the classic singular label field, which is now hidden, so editing only the DataForm label will not auto-fill the key. The key is still editable in DataForm and saves as typed. Built assets are gitignored, so a source checkout needs
npm run buildbefore the editor loads.