Repository navigation
Publish the SwerveDrive tuning command at Tuning/<name>/Live Tuning - #248
Merged
Merged
Conversation
…like every other mechanism It was at Mechanisms/<name>/tuning, apart from the Live Tuning commands of motor controllers and SwerveInputStream. It is now named Live Tuning and published through the Tuning backend, beside the drive's tuning values. MIGRATION.md notes the move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every live tuning command in YAMS lives at `NT:/Tuning//Live Tuning` except `SwerveDrive`'s, which was published at `NT:/Mechanisms//tuning`. Its tuning values were already under `NT:/Tuning//`, so the command and its values were in different tables.
This renames an NT key, so dashboards that start the command at the old path need updating. The YAMS-Gitbook docs and the YAGSL config generator's live tuning are being moved in companion PRs.
Tested: the Java swerve tests (
./gradlew test --rerun --tests '*Swerve*', 204 passed, 0 failed) and the C++ swerve tests (-PcatchFilter='[SwerveDriveTest]', 186 assertions in 43 test cases) pass. The rest of the suites have not been run.