feat(frontend): add preflight simulation before value-moving transactions - #270
Open
woahwhattheheck wants to merge 1 commit into
Open
woahwhattheheck wants to merge 1 commit into
woahwhattheheck wants to merge 1 commit into
Conversation
Run a read-only preflight against the current wallet, network, and serialized deposit/withdraw payload before requesting a signature. Deterministic failures (stale balance, paused vault, contract rejection, network mismatch) block signing; provider timeouts and unsupported simulation responses offer an explicit retry. Successful simulation is advisory only — on-chain validation remains authoritative. Closes YieldVault-Org#264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #264.
Adds a read-only preflight simulation step for deposits and withdrawals so deterministic failures are caught before the wallet asks for a signature. Successful simulation is advisory only; contract-side validation and the provider result remain authoritative.
Trust boundary
status: oknever means the transfer is confirmed or settled.Race / invalidation handling
fingerprint = network::serializedTx.staleand blocks signing until preflight is run again.User-visible states
runningokrejectedtimeout/unsupportedstaleAcceptance criteria
Test evidence
test/utils/preflight.test.js— serialize / fingerprint / binding / signature gatetest/services/preflight.test.js— success, contract rejection, timeout, unsupported, stale balance, paused vault, network mismatch, insufficient positiontest/hooks/usePreflight.test.jsx— changed payload, network switch, timeout retrytest/components/DepositForm.preflight.test.jsx— nosignAndSubmiton reject / timeout / stale / wrong network; success still signsnpm test— 236 passed.tsc -b— clean for touched packages.Out of scope