Repository navigation
fix(compat): get a v0.3 push config by task id alone - #1380
mykytanetipa merged 3 commits into
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/compat/v0_3/request_handler.py | 96.97% | 97.40% | 🟢 +0.43% |
| Total | 93.42% | 93.42% | 🟢 +0.01% |
Generated by coverage-comment.yml
mykytanetipa
left a comment
There was a problem hiding this comment.
This only fixes configs that were created without an id. v0.3 clients can also set their own config id, and then get by task id alone still fails:
set: {"taskId": "task-1", "pushNotificationConfig": {"id": "cfg-1", "url": "https://..."}}
get: {"id": "task-1"}
The get looks up config "task-1", finds nothing, and the v1.0 handler raises TaskNotFoundError even though the task exists. v0.3.26 returned the task's first config here.
When no id is given, list the task's configs instead. Prefer the one stored under the task id, otherwise take the first:
if not v10_req.id:
resp = await self.request_handler.on_list_task_push_notification_configs(
ListTaskPushNotificationConfigsRequest(task_id=v10_req.task_id),
context,
)
configs = list(resp.configs)
chosen = next(
(c for c in configs if c.id == v10_req.task_id),
configs[0] if configs else None,
)
if chosen is None:
raise TaskNotFoundError
return conversions.to_compat_task_push_notification_config(chosen)Please also add a test that goes through DefaultRequestHandlerV2 with InMemoryPushNotificationConfigStore, covering set with and without an id. The current test mocks the core handler, so it doesn't catch this.
|
Thanks, you're right. It now lists the task's configs when no id is given and prefers the one stored under the task id, otherwise the first. Swapped the mocked test for one through DefaultRequestHandlerV2 and InMemoryPushNotificationConfigStore that covers set with and without an id. |
🤖 I have created a release *beep* *boop* --- ## [1.3.1](v1.3.0...v1.3.1) (2026-11-16) ### Features * add httpx2 support ([#1439](#1439)) ([a59bb68](a59bb68)) * **cluster:** Introduce ServerCallContext to DatabaseTaskEventStream ([#1399](#1399)) ([6168d59](6168d59)) ### Bug Fixes * **client:** handle case-insensitive SSE media types ([#1464](#1464)) ([3932982](3932982)) * **client:** keep tenant defaults local to each call ([#1463](#1463)) ([569b94f](569b94f)) * **client:** percent-encode ids in REST transport paths ([#1436](#1436)) ([1bbe69c](1bbe69c)) * **client:** split SSE lines only on CR, LF and CRLF ([#1456](#1456)) ([c8ccea9](c8ccea9)) * **compat:** get a v0.3 push config by task id alone ([#1380](#1380)) ([aa8e966](aa8e966)) * **compat:** list push notification configs in the v0.3 REST client ([#1424](#1424)) ([d830036](d830036)), closes [#1423](#1423) * **compat:** map v0.3 gRPC errors from their ErrorInfo reason ([#1466](#1466)) ([caab6a2](caab6a2)) * **compat:** parse the v0.3 REST extended agent card as JSON ([#1420](#1420)) ([076e0ec](076e0ec)) * **compat:** percent-encode ids in v0.3 REST transport paths ([#1458](#1458)) ([1ff86d5](1ff86d5)) * **compat:** return -32602 for invalid v0.3 JSON-RPC params ([#1419](#1419)) ([05aaff6](05aaff6)) * **compat:** return 400 for a non-integer v0.3 REST historyLength ([#1382](#1382)) ([9c90c48](9c90c48)), closes [#1381](#1381) * **compat:** return HTTP errors from v0.3 REST streams that fail early ([#1403](#1403)) ([11f1116](11f1116)) * **compat:** send no v0.3 configuration when the request has none ([#1429](#1429)) ([01483cb](01483cb)) * **compat:** send v0.3 REST request bodies with json_name keys ([#1455](#1455)) ([2399993](2399993)) * **compat:** serve DELETE for v0.3 REST push notification configs ([#1442](#1442)) ([14e799c](14e799c)) * reject decoded values that are not objects in parse_lenient ([#1431](#1431)) ([257626b](257626b)) * reject invalid REST boolean query values ([#1383](#1383)) ([babc3f5](babc3f5)) * **server:** close the event queues when ActiveTask.start() fails ([#1422](#1422)) ([5e0d415](5e0d415)) * **server:** create the cluster tables lazily in VersionedDatabaseTaskStore get and delete ([#1357](#1357)) ([4e133b7](4e133b7)) * **server:** fail fast when an executor produces no events ([#1345](#1345)) ([ab7e36f](ab7e36f)) * **server:** fail streaming sends when an executor produces no events ([#1460](#1460)) ([c16cab1](c16cab1)) * **server:** forward CancelTaskRequest.metadata to AgentExecutor.cancel ([#1416](#1416)) ([f666ba3](f666ba3)), closes [#1415](#1415) * **server:** infer contextId from task when only taskId is provided ([#1453](#1453)) ([2ba8e7b](2ba8e7b)), closes [#1411](#1411) * **server:** match input modes on type and subtype, ignoring case ([#1425](#1425)) ([28f8a62](28f8a62)) * **server:** prevent failed cancel from overwriting terminal task state ([#1405](#1405)) ([ac48ce1](ac48ce1)) * **server:** record FAILED when a task's terminal save fails ([#1400](#1400)) ([4e916d8](4e916d8)) * **server:** reject out-of-range ListTasks cursor timestamps ([#1451](#1451)) ([f451ed7](f451ed7)) * **server:** run after_handler_run when a handler call is cancelled ([#1427](#1427)) ([2cc1dd5](2cc1dd5)) * **server:** treat request bodies that are not valid UTF-8 as parse errors ([#1401](#1401)) ([56ec855](56ec855)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Problem
A v0.3
pushNotificationConfig/getwith only a task id failed validation, because the v1.0 request had no config id.Fix
When no config id is given, list the task's configs and return the one stored under the task id, otherwise the first. This matches v0.3.
Tests
test_on_get_task_push_notification_config_by_task_idruns throughDefaultRequestHandlerV2andInMemoryPushNotificationConfigStore. It covers a set with and without an id and fails on main. 2329 passed.Fixes #1379