Skip to content

fix(compat): return HTTP errors from v0.3 REST streams that fail early - #1403

Merged
Iwaniukooo11 merged 2 commits into
a2aproject:mainfrom
jaeminbird:fix/v03-rest-stream-bad-body
Nov 2, 2026
Merged

Iwaniukooo11 merged 2 commits into
a2aproject:mainfrom
jaeminbird:fix/v03-rest-stream-bad-body

Conversation

@jaeminbird

Copy link
Copy Markdown
Contributor

Description

The v0.3 REST adapter starts the SSE response before the handler runs, so any error raised before the first event becomes an empty 200 text/event-stream: a malformed message:stream body (even {bad), or tasks/{id}:subscribe for an unknown task. message:send answers 400 for the same body, and the v1.0 routes answer 400/404.

_handle_streaming_request now fetches the first event before creating the response, as RestDispatcher._handle_streaming already does, so @rest_stream_error_handler maps these errors to the usual JSON error. Mid-stream behaviour is unchanged. Follow-up to #1401, which noted this as a separate problem.

  • New tests (malformed message:stream → 400, unknown-task subscribe → 404, events still streamed in order) fail on main and pass with the fix.

  • scripts/lint.sh and uv run pytest on Linux pass.

  • Follow the CONTRIBUTING Guide.

  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.

  • Ensure the tests and linter pass

  • Appropriate docs were updated (not needed)

The v0.3 REST adapter started the SSE response before running the
handler, so a malformed message:stream body or an unknown task on
tasks/{id}:subscribe produced an empty 200 text/event-stream. Fetch the
first event before starting the stream, as the v1.0 REST dispatcher
does, so these errors get the same JSON error response as message:send.
@jaeminbird
jaeminbird requested a review from a team as a code owner October 29, 2026 09:54
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🧪 Code Coverage (vs main)

⬇️ Download Full Report

Base PR Delta
src/a2a/compat/v0_3/rest_adapter.py 77.14% 78.05% 🟢 +0.91%
Total 93.42% 93.42% 🔴 -0.01%

Generated by coverage-comment.yml

@Iwaniukooo11 Iwaniukooo11 self-assigned this Oct 30, 2026

@Iwaniukooo11 Iwaniukooo11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Iwaniukooo11
Iwaniukooo11 merged commit 11f1116 into a2aproject:main Nov 2, 2026
17 checks passed
Linux2010 added a commit to Linux2010/a2a-python that referenced this pull request Nov 2, 2026
a2aproject#1403 is an error-handling divergence on the v0.3 REST surface rather than a
field-mapping one, so describe it as the second shape the same gRPC-vs-
JSON-RPC/REST split produces instead of implying it dropped a field.

Signed-off-by: andy <linux2011@qq.com>
@jaeminbird
jaeminbird deleted the fix/v03-rest-stream-bad-body branch November 3, 2026 05:30
Linux2010 added a commit to Linux2010/a2a-python that referenced this pull request Nov 12, 2026
a2aproject#1403 is an error-handling divergence on the v0.3 REST surface rather than a
field-mapping one, so describe it as the second shape the same gRPC-vs-
JSON-RPC/REST split produces instead of implying it dropped a field.

Signed-off-by: andy <linux2011@qq.com>
Linux2010 added a commit to Linux2010/a2a-python that referenced this pull request Nov 13, 2026
a2aproject#1403 is an error-handling divergence on the v0.3 REST surface rather than a
field-mapping one, so describe it as the second shape the same gRPC-vs-
JSON-RPC/REST split produces instead of implying it dropped a field.

Signed-off-by: andy <linux2011@qq.com>
Linux2010 added a commit to Linux2010/a2a-python that referenced this pull request Nov 14, 2026
a2aproject#1403 is an error-handling divergence on the v0.3 REST surface rather than a
field-mapping one, so describe it as the second shape the same gRPC-vs-
JSON-RPC/REST split produces instead of implying it dropped a field.

Signed-off-by: andy <linux2011@qq.com>
Linux2010 added a commit to Linux2010/a2a-python that referenced this pull request Nov 16, 2026
a2aproject#1403 is an error-handling divergence on the v0.3 REST surface rather than a
field-mapping one, so describe it as the second shape the same gRPC-vs-
JSON-RPC/REST split produces instead of implying it dropped a field.

Signed-off-by: andy <linux2011@qq.com>
Linux2010 added a commit to Linux2010/a2a-python that referenced this pull request Nov 16, 2026
a2aproject#1403 is an error-handling divergence on the v0.3 REST surface rather than a
field-mapping one, so describe it as the second shape the same gRPC-vs-
JSON-RPC/REST split produces instead of implying it dropped a field.

Signed-off-by: andy <linux2011@qq.com>
Linux2010 added a commit to Linux2010/a2a-python that referenced this pull request Nov 16, 2026
a2aproject#1403 is an error-handling divergence on the v0.3 REST surface rather than a
field-mapping one, so describe it as the second shape the same gRPC-vs-
JSON-RPC/REST split produces instead of implying it dropped a field.

Signed-off-by: andy <linux2011@qq.com>
Iwaniukooo11 pushed a commit that referenced this pull request Nov 17, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.3.1](v1.3.0...v1.3.1)
(2026-11-16)


### Features

* add httpx2 support
([#1439](#1439))
([a59bb68](a59bb68))
* **cluster:** Introduce ServerCallContext to DatabaseTaskEventStream
([#1399](#1399))
([6168d59](6168d59))


### Bug Fixes

* **client:** handle case-insensitive SSE media types
([#1464](#1464))
([3932982](3932982))
* **client:** keep tenant defaults local to each call
([#1463](#1463))
([569b94f](569b94f))
* **client:** percent-encode ids in REST transport paths
([#1436](#1436))
([1bbe69c](1bbe69c))
* **client:** split SSE lines only on CR, LF and CRLF
([#1456](#1456))
([c8ccea9](c8ccea9))
* **compat:** get a v0.3 push config by task id alone
([#1380](#1380))
([aa8e966](aa8e966))
* **compat:** list push notification configs in the v0.3 REST client
([#1424](#1424))
([d830036](d830036)),
closes [#1423](#1423)
* **compat:** map v0.3 gRPC errors from their ErrorInfo reason
([#1466](#1466))
([caab6a2](caab6a2))
* **compat:** parse the v0.3 REST extended agent card as JSON
([#1420](#1420))
([076e0ec](076e0ec))
* **compat:** percent-encode ids in v0.3 REST transport paths
([#1458](#1458))
([1ff86d5](1ff86d5))
* **compat:** return -32602 for invalid v0.3 JSON-RPC params
([#1419](#1419))
([05aaff6](05aaff6))
* **compat:** return 400 for a non-integer v0.3 REST historyLength
([#1382](#1382))
([9c90c48](9c90c48)),
closes [#1381](#1381)
* **compat:** return HTTP errors from v0.3 REST streams that fail early
([#1403](#1403))
([11f1116](11f1116))
* **compat:** send no v0.3 configuration when the request has none
([#1429](#1429))
([01483cb](01483cb))
* **compat:** send v0.3 REST request bodies with json_name keys
([#1455](#1455))
([2399993](2399993))
* **compat:** serve DELETE for v0.3 REST push notification configs
([#1442](#1442))
([14e799c](14e799c))
* reject decoded values that are not objects in parse_lenient
([#1431](#1431))
([257626b](257626b))
* reject invalid REST boolean query values
([#1383](#1383))
([babc3f5](babc3f5))
* **server:** close the event queues when ActiveTask.start() fails
([#1422](#1422))
([5e0d415](5e0d415))
* **server:** create the cluster tables lazily in
VersionedDatabaseTaskStore get and delete
([#1357](#1357))
([4e133b7](4e133b7))
* **server:** fail fast when an executor produces no events
([#1345](#1345))
([ab7e36f](ab7e36f))
* **server:** fail streaming sends when an executor produces no events
([#1460](#1460))
([c16cab1](c16cab1))
* **server:** forward CancelTaskRequest.metadata to AgentExecutor.cancel
([#1416](#1416))
([f666ba3](f666ba3)),
closes [#1415](#1415)
* **server:** infer contextId from task when only taskId is provided
([#1453](#1453))
([2ba8e7b](2ba8e7b)),
closes [#1411](#1411)
* **server:** match input modes on type and subtype, ignoring case
([#1425](#1425))
([28f8a62](28f8a62))
* **server:** prevent failed cancel from overwriting terminal task state
([#1405](#1405))
([ac48ce1](ac48ce1))
* **server:** record FAILED when a task's terminal save fails
([#1400](#1400))
([4e916d8](4e916d8))
* **server:** reject out-of-range ListTasks cursor timestamps
([#1451](#1451))
([f451ed7](f451ed7))
* **server:** run after_handler_run when a handler call is cancelled
([#1427](#1427))
([2cc1dd5](2cc1dd5))
* **server:** treat request bodies that are not valid UTF-8 as parse
errors ([#1401](#1401))
([56ec855](56ec855))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Linux2010 added a commit to Linux2010/a2a-python that referenced this pull request Nov 17, 2026
a2aproject#1403 is an error-handling divergence on the v0.3 REST surface rather than a
field-mapping one, so describe it as the second shape the same gRPC-vs-
JSON-RPC/REST split produces instead of implying it dropped a field.

Signed-off-by: andy <linux2011@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants