Repository navigation
ci: correct the actions/checkout version comment on eight pins - #1509
Open
chopmob-cloud wants to merge 1 commit into
Open
chopmob-cloud wants to merge 1 commit into
chopmob-cloud wants to merge 1 commit into
Conversation
Eight workflow steps pin actions/checkout to 3d3c42e5aac5ba805825da76410c181273ba90b1 but label it `# v6`. That SHA is v7.0.1 — `v6` resolves to d23441a48e — so the comment misreports the version a reader would use when auditing or bumping it. The pins themselves are correct and unchanged; only the comment text moves. An independent review of the pinning change flagged two of these lines; the same mistake is in eight places across four files, so all eight are corrected here. Verified comment-only: the clean-room gate parses all 17 workflows, confirms no v6 label remains and all eight read v7.0.1, and asserts the 58 `uses:` values are identical to main — nothing but comment text moved. Two negative controls fire: reintroducing a v6 label, and changing an action reference. Refs a2aproject#1314 Signed-off-by: AlgoVoi <chopmob@gmail.com>
🧪 Code Coverage (vs
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight workflow steps pin
actions/checkoutto3d3c42e5aac5ba805825da76410c181273ba90b1but label it# v6. That SHA is v7.0.1;v6resolves tod23441a48e. The pins are correct — only the comment is wrong, which misleads anyone auditing or bumping it..github/workflows/linter.yaml.github/workflows/python-publish.yml.github/workflows/run-tck.yaml.github/workflows/unit-tests.ymlFound while auditing action pins: an independent review of the pinning change (#1314) flagged two of these lines, and the same mistake appears in eight places across four files.
Verification
Clean-room gate on VM2 (
python:3.12-slim):0pins still labelled v6;8now labelled v7.0.1uses:values are identical tomain— the strongest statement available for a comment-only change: nothing but comment text moved# v6label is caughtThe gated tree (
c0dd627e…) is byte-identical to the committed tree, so the green result covers this commit.Diff is 8 lines changed,
+8/−8, no line-ending or whitespace churn (verified with--numstat, equal insertions and deletions per file).Refs #1314. This is deliberately separate from the pinning change so that PR stays scoped to pinning.