Repository navigation
fix(client): skip incompatible transport bindings when selecting an interface - #1510
Open
GoldArowana wants to merge 1 commit into
Open
GoldArowana wants to merge 1 commit into
GoldArowana wants to merge 1 commit into
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/client/client_factory.py | 89.94% | 90.23% | 🟢 +0.29% |
| src/a2a/server/cluster/database_event_stream.py | 97.27% | 93.64% | 🔴 -3.64% |
| Total | 94.14% | 94.11% | 🔴 -0.03% |
Generated by coverage-comment.yml
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With server preference enabled by default,
ClientFactory.createstops at the first configured transport binding even when the card advertises no usable protocol version for it. A card that lists a 0.2 JSON-RPC interface before a 1.0 HTTP+JSON interface therefore raisesValueError: no compatible transports found, despite the client supporting the second interface.Continue through the advertised transport order when the existing version selector finds no match. The existing version ranking within a binding and the error when all interfaces are incompatible remain unchanged. See A2A 1.0 §8.3.2.
Testing
06cd52892e45and passes with this change.622a12d9d1d8passed.uv run pytestanduv run pytest --cov=src --cov-report=term-missingeach passed 2,676 tests, with 215 project-configured skips, four expected failures and one unexpected pass. The coverage run reported 94%. Local PostgreSQL and MySQL integration services were unavailable, so their tests retained their normal skips.Codex assisted with implementation and test execution.