Skip to content

fix: accept extensions in chunk size lines - #1553

Open
fhgffy wants to merge 2 commits into
abhinavsingh:developfrom
fhgffy:fix-chunk-extension-parsing
Open

fhgffy wants to merge 2 commits into
abhinavsingh:developfrom
fhgffy:fix-chunk-extension-parsing

Conversation

@fhgffy

@fhgffy fhgffy commented Oct 13, 2026

Copy link
Copy Markdown

A valid chunk size such as 4;name=value raises ValueError because the parser passes the entire line to the hexadecimal conversion. Parse only the size before the extension separator.

The regression decodes a body with extensions on both a data chunk and the terminating chunk, and verifies the complete body and parser state.

Validation: the socket/parser test suite passes. The full Windows run has the same two failures as unmodified develop: the HTTP/2 SSL-context call and the connection-error fixture.

@pyba-chronographer pyba-chronographer Bot added the bot:chronographer:provided Used by chronographer to mark a PR as CHANGELOG provider label Oct 13, 2026
@fhgffy
fhgffy marked this pull request as ready for review October 13, 2026 17:19

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided Used by chronographer to mark a PR as CHANGELOG provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant