Point CI workflows at the ably-pubsub-go sdk-builds role - #711
Draft
umair-ably wants to merge 1 commit into
Draft
Conversation
Workflows-only preparation for the rename ably-go -> ably-pubsub-go: the sdk-builds IAM role and godoc source-link in docs.yml, and the features workflow repository-name. The Go module path and every import, README install snippets and pkg.go.dev links are deliberately not touched here: under the copy-then-rename plan the old name is reclaimed by the maintenance copy, so the module path change is a breaking change that belongs with the split rather than the rename. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge until the repository is renamed
ably-go→ably-pubsub-go, in the programme's rename freeze window. Merging early pointsdocs.ymlandfeatures.ymlat theably-sdk-builds-ably-pubsub-goIAM role, whose OIDC trust is bound to the new repository name, so the credential step would fail. Conversely, once the rename happens the old role name stops matching, so this is a same-window change in both directions.Why workflows-only
ably-go follows the copy-then-rename route in PDR-091b2: a maintenance copy keeps the
ably/ably-goname, and this repo is renamed. Because the old name is reclaimed there is no GitHub redirect, and a Go module path is its repo path. Changingmodule github.com/ably/ably-gotogithub.com/ably/ably-pubsub-gorewrites every import in the repo and is a breaking change for consumers, so it belongs with the split (#709) and the newpubsub/core,pubsub/device,pubsub/serverpackages, not with the rename. The same goes for the READMEgo getline, pkg.go.dev badges/links,UPDATING.md,CONTRIBUTING.mdandably/doc.go.This PR carries only what the rename itself breaks. Sibling of the rename PRs in the other SDK repos (ably-pubsub-ruby#457 et al.).
What changed
.github/workflows/docs.yml—role-to-assume→ably-sdk-builds-ably-pubsub-go, and the gopages-source-linkbase, which links each godoc symbol to its source file in this repo (no redirect once the old name is reclaimed)..github/workflows/features.yml—repository-name: ably-pubsub-go.The
ably-pubsub-gosdk-builds role exists (infrastructure#13005) but, unlike the other renamed repos, has no ID-qualified OIDC subject in its trust policy. The renamed repo keeps its numeric ID and GitHub issues the ID-qualified subject for repos renamed after 2026-07-15, so without that entry the credential step fails post-rename. Tracked in https://github.com/ably/infrastructure/pull/13087; merge and apply that first.Post-rename verification
docs.ymlandfeatures.ymlruns: AWS credential step succeeds and the upload lands atsdk.ably.com/builds/ably/ably-pubsub-go/main/…(the upload failure mode is silent).maininto the split branch (pubsub: add device and server packages #709), which carries its own copies of these workflows.🤖 Generated with Claude Code