Skip to content

Point CI workflows at the ably-pubsub-go sdk-builds role - #711

Draft
umair-ably wants to merge 1 commit into
mainfrom
pubsub-split/rename-references-workflows
Draft

Point CI workflows at the ably-pubsub-go sdk-builds role#711
umair-ably wants to merge 1 commit into
mainfrom
pubsub-split/rename-references-workflows

Conversation

@umair-ably

@umair-ably umair-ably commented Sep 8, 2026

Copy link
Copy Markdown

Do not merge until the repository is renamed ably-goably-pubsub-go, in the programme's rename freeze window. Merging early points docs.yml and features.yml at the ably-sdk-builds-ably-pubsub-go IAM role, whose OIDC trust is bound to the new repository name, so the credential step would fail. Conversely, once the rename happens the old role name stops matching, so this is a same-window change in both directions.

Why workflows-only

ably-go follows the copy-then-rename route in PDR-091b2: a maintenance copy keeps the ably/ably-go name, and this repo is renamed. Because the old name is reclaimed there is no GitHub redirect, and a Go module path is its repo path. Changing module github.com/ably/ably-go to github.com/ably/ably-pubsub-go rewrites every import in the repo and is a breaking change for consumers, so it belongs with the split (#709) and the new pubsub/core, pubsub/device, pubsub/server packages, not with the rename. The same goes for the README go get line, pkg.go.dev badges/links, UPDATING.md, CONTRIBUTING.md and ably/doc.go.

This PR carries only what the rename itself breaks. Sibling of the rename PRs in the other SDK repos (ably-pubsub-ruby#457 et al.).

What changed

  • .github/workflows/docs.ymlrole-to-assumeably-sdk-builds-ably-pubsub-go, and the gopages -source-link base, which links each godoc symbol to its source file in this repo (no redirect once the old name is reclaimed).
  • .github/workflows/features.ymlrepository-name: ably-pubsub-go.

⚠️ Infrastructure prerequisite

The ably-pubsub-go sdk-builds role exists (infrastructure#13005) but, unlike the other renamed repos, has no ID-qualified OIDC subject in its trust policy. The renamed repo keeps its numeric ID and GitHub issues the ID-qualified subject for repos renamed after 2026-07-15, so without that entry the credential step fails post-rename. Tracked in https://github.com/ably/infrastructure/pull/13087; merge and apply that first.

Post-rename verification

  • docs.yml and features.yml runs: AWS credential step succeeds and the upload lands at sdk.ably.com/builds/ably/ably-pubsub-go/main/… (the upload failure mode is silent).
  • godoc source links resolve against the renamed repo.
  • Merge main into the split branch (pubsub: add device and server packages #709), which carries its own copies of these workflows.

🤖 Generated with Claude Code

Workflows-only preparation for the rename ably-go -> ably-pubsub-go:
the sdk-builds IAM role and godoc source-link in docs.yml, and the
features workflow repository-name.

The Go module path and every import, README install snippets and
pkg.go.dev links are deliberately not touched here: under the
copy-then-rename plan the old name is reclaimed by the maintenance
copy, so the module path change is a breaking change that belongs with
the split rather than the rename.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant