[Accton] modules: extract accton_ipmi_intf into common kernel-module … - #213
Open
eric271110 wants to merge 1 commit into
Open
[Accton] modules: extract accton_ipmi_intf into common kernel-module …#213eric271110 wants to merge 1 commit into
eric271110 wants to merge 1 commit into
Conversation
…source tree Platforms: as7535-28xb, as7926-40xfb, as7946-30xb, as7946-74xkb, as9737-32db, as9817-64, as9926-24db. * Move the accton_ipmi_intf.c / accton_ipmi_intf.h kernel-module source that was duplicated in every platform's src/modules tree into a shared source directory under packages/platforms/accton/x86-64/common/modules/src, so all Accton x86-64 platforms build from one copy instead of per-platform duplicates. * Add a shared build helper kmodule-stage.mk under packages/platforms/accton/x86-64/common/modules. It stages the platform's own src/modules contents plus a caller-supplied list of shared basenames (ACCTON_COMMON_KMOD_SRCS) into a temporary .stage directory and hands that merged tree to kmodbuild.sh via the standard KMODULES variable. Add a README.md next to the helper describing the layout and how a platform opts in. * Update each platform's modules/builds/Makefile to include kmodule-stage.mk instead of make/kmodule.mk, set ACCTON_COMMON_KMOD_SRCS := accton_ipmi_intf, and change KMODULES to $(CURDIR)/src so the stager can locate the platform-local sources from any working directory. Add .stage to each platform's modules/builds/.gitignore so the staging directory is not tracked. * Remove the per-platform copies of accton_ipmi_intf.c / accton_ipmi_intf.h under each platform's modules/builds/src (and as9817-64/src/modules) now that the shared source is used. Signed-off-by: Eric Yang <eric_yang@accton.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…source tree
Platforms: as7535-28xb, as7926-40xfb, as7946-30xb, as7946-74xkb, as9737-32db, as9817-64, as9926-24db.