Skip to content

[mri_violations] Add missing translations (db and non-db)#10839

Open
HachemJ wants to merge 4 commits into
aces:29.0-releasefrom
HachemJ:AddMissingTranslationsMriViolations
Open

[mri_violations] Add missing translations (db and non-db)#10839
HachemJ wants to merge 4 commits into
aces:29.0-releasefrom
HachemJ:AddMissingTranslationsMriViolations

Conversation

@HachemJ

@HachemJ HachemJ commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Brief summary of changes

This PR adds missing non db translations and the following db translation 'Default MRI protocol group' accessible when you click on 'Type of Problem' entry of any row in the MRI Violated Scans page.

Link(s) to related issue(s)

@github-actions github-actions Bot added RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset Language: Javascript PR or issue that update Javascript code Module: mri_violations PR or issue related to mri_violations module Multilingual Any tasks related to making LORIS multilingual labels Jul 8, 2026

const pushgroup = (name, tablerows) => {
protocolgroups.push(<div>
<h3>{name}</h3>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change was supposed to be committed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't at all. I'm still working on the PR because I couldn't make the db translation go through yet but Saagar has been helping me trying to figure out what's wrong because this is my first time dealing with db translations and that's why I opened the PR early. I should have had the Label 'Needs work' on sorry.

@HachemJ HachemJ added 29.0.0 - Bugs Issues found during the release testing for 29.0.0 State: Needs work PR awaiting additional work by the author to proceed labels Jul 8, 2026
@github-actions github-actions Bot added the Language: PHP PR or issue that update PHP code label Jul 8, 2026
@HachemJ HachemJ removed the State: Needs work PR awaiting additional work by the author to proceed label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

29.0.0 - Bugs Issues found during the release testing for 29.0.0 Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: mri_violations PR or issue related to mri_violations module Multilingual Any tasks related to making LORIS multilingual RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants