[Instruments] Remove Excluded Instruments from DD and DQT#10843
Open
sruthymathew123 wants to merge 1 commit into
Open
[Instruments] Remove Excluded Instruments from DD and DQT#10843sruthymathew123 wants to merge 1 commit into
sruthymathew123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Instruments added to the "Excluded instruments" configuration setting were
still queryable in the Data Dictionary module and the DQT. The
excluded_instrumentssetting was was not considered by the instrument query engine that both modules use.Testing instructions (if applicable)
to the "Excluded instruments" section, then save.
appear as a category, and none of its fields should be listed.
the excluded instrument and its fields should not be available for
querying.
"Excluded instruments" list, and save.
and the DQT without any additional steps.
Link(s) to related issue(s)