Add setRaw() method for Set type encoder (#1086) - #1122
Merged
Conversation
vyazelenko
requested changes
Sep 9, 2026
vyazelenko
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good. Just minor things with a test.
Contributor
Author
|
@vyazelenko |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getRaw()is generated in the decoder forSet(bitset) types, but thesymmetric
setRaw()method is missing from the generated encoder,preventing direct writes of a raw bitset value without going through
individual choice setters.
Fixes #1086
Solution
Added generation of
setRaw()inJavaGenerator#generateBitSet, mirroringthe existing
getRaw()decoder logic, using the samegeneratePutmechanism already used elsewhere in the generator.
Testing
Added
shouldGenerateBitSetRawAccessorinJavaGeneratorTest, whichencodes a raw value via
setRaw()and verifies it round-trips correctlythrough the existing
getRaw()decoder method.All existing tests pass, including
shouldGenerateBitSetCodecs.