Identity: Move actor JWT/cert minting into the main API - #1315
Open
Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Open
Identity: Move actor JWT/cert minting into the main API#1315Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Conversation
Taahir Ahmed (ahmedtd)
force-pushed
the
merge-broker
branch
3 times, most recently
from
September 2, 2026 01:31
571be1b to
f501545
Compare
Taahir Ahmed (ahmedtd)
marked this pull request as draft
September 3, 2026 20:48
Collaborator
Author
|
Whoops, this isn't ready to review yet. |
Taahir Ahmed (ahmedtd)
changed the title
Taahir Ahmed (ahmedtd)
force-pushed
the
merge-broker
branch
2 times, most recently
from
September 4, 2026 20:16
943838f to
10a0120
Compare
Taahir Ahmed (ahmedtd)
marked this pull request as ready for review
September 4, 2026 20:17
Collaborator
Author
|
Ready for review now |
This was originally a separate service to make it easy to apply separate authentication and authorization interceptors. It now seems clear that they should be in controlapi, with the same authn/z handlers chosen there. * Remove checks that will be handled in the authorizer framework.
Taahir Ahmed (ahmedtd)
force-pushed
the
merge-broker
branch
from
September 4, 2026 20:58
10a0120 to
461bc37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally a separate service to make it easy to apply separate authentication and authorization interceptors.
It now seems clear that our authn/z framework will be strong enough to support atelet and external callers in one system (based on OpenFGA).
This change moves the MintJWT and MintCert RPCs into the control API, and removes some inline authz checks that will be handled by our unified authorizer framework.