Regression: #2760 dropped permission context when loading legacy v1 session state (re-opens #2768)

[chang6666]

Summary

#2769 fixed #2768 ("ReActAgent legacy-state load silently drops permissionContext (downgrades to DEFAULT)") by forwarding the caller's permCtx to LegacyStateLoader. Commit 6059782 (#2760) rewrote ReActAgent.loadOrCreateAgentStateForSlot(...) and dropped that argument, calling the 3-arg LegacyStateLoader.loadFromLegacySessionWithPresence(stateStore, userId, sessionId) overload again — so the regression described in #2768 is live on main again.

Impact

Same as #2768: any session that still has v1-era keys (memory_messages / toolkit_activeGroups) but no new-format agent_state — typically the first turn after a 1.x → 2.0 migration — gets its caller-configured permission mode (e.g. BYPASS) silently downgraded to DEFAULT.

Repro / Fix

• Repro: seed v1 legacy keys, build an agent with permissionContext(BYPASS), perform the first call() — the reconstructed state comes back DEFAULT instead of BYPASS.
• Fix: PR fix(core): pass builder permission context when loading legacy v1 session state #2886 (passes permCtx to the 4-arg overload; includes an end-to-end regression test ReActAgentLegacyPermissionContextTest that fails on current main with expected: <BYPASS> but was: <DEFAULT>).

[oss-maintainer]

Issue Evaluation

Category: bug | Area: area/core/agent | Status: Confirmed regression (verified against current main)

Root Cause: ReActAgent.loadOrCreateAgentStateForSlot receives the caller's permCtx and uses it for the fresh-state path, but its legacy-state path calls the 3-arg LegacyStateLoader.loadFromLegacySessionWithPresence(stateStore, userId, sessionId) overload, which forwards null and silently downgrades a caller-configured permission mode (e.g. BYPASS) to DEFAULT. This re-introduces the behaviour already fixed in #2769 for #2768 after #2760 rewrote the method.
Impact: Any session that still has v1-era keys (memory_messages / toolkit_activeGroups) but no new-format state loses its permission context on load.
Severity: high

The fix is to forward permCtx through the legacy load path (the same shape as #2886). Please ensure a regression test pins the legacy + permission-context combination.

---

Automated evaluation by github-manager-bot