fix(harness): skip composite routes for PathPolicy host mounts - #2892
Open
jialiuyang wants to merge 1 commit into
Open
fix(harness): skip composite routes for PathPolicy host mounts#2892jialiuyang wants to merge 1 commit into
jialiuyang wants to merge 1 commit into
Conversation
Strip-leading-slash routing made /knowledge/file.md match the knowledge/ store, so a host mount at that path was never read. Extra PathPolicy roots outside the workspace (and optional constructor hostRoots) now stay on the default backend. Workspace-relative knowledge/ paths still use the route. Fixes agentscope-ai#2690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.x (main)
Description
CompositeFilesystem.routeForPathstrips a leading slash before prefix matching so/skills/fooandskills/foohit the same store. That also makes a host path such as/knowledge/services.mdmatch theknowledge/route. The request is forwarded to the remote/overlay segment (usually empty) and the file on the host mount is never read — no exception, just a failed result.This change treats extra
PathPolicyroots on aLocalFilesystemdefault backend (anything other than the workspace cwd) as host mounts and keeps those absolute paths on the default backend. An optional constructor argument accepts the same roots when the default store is notLocalFilesystem. Workspace-relativeknowledge/...paths still use the route.Fixes #2690
Checklist
mvn spotless:applyCompositeFilesystemTest)