Skip to content

Invalid license tag #57

Description

@Finomnis

cargo-licenses does not pick up this crate's license properly because it's not a proper licence string.

/ is not a defined separator, so MIT/Apache-2.0 does not get separated.

The proper tag is MIT OR Apache-2.0 (see for example https://github.com/serde-rs/serde/blob/master/serde_core/Cargo.toml)

So when I run a license check in my CI, I get:

$ cargo-licenses check --allow MIT --allow Apache-2.0
License check failed: License check found these violations:
Crate 'ringbuf': sub-license 'MIT/Apache-2.0' is NOT in the allow list.

When I run cargo-licenses generate on my repository, I get:

# License Report
This report lists direct dependencies (async) and their matched licenses.

- **either** (version: `1.16.0`) → *MIT OR Apache-2.0*
- **sha2** (version: `0.11.0`) → *MIT OR Apache-2.0*
- **ciborium** (version: `0.2.2`) → *Apache-2.0*
- **miette** (version: `7.6.0`) → *Apache-2.0*
- **hex** (version: `0.4.3`) → *MIT OR Apache-2.0*
- **serde_repr** (version: `0.1.20`) → *MIT OR Apache-2.0*
- **serialport** (version: `4.9.0`) → *MPL-2.0*
- **crc** (version: `3.4.0`) → *MIT OR Apache-2.0*
- **serde_bytes** (version: `0.11.19`) → *MIT OR Apache-2.0*
- **base64** (version: `0.22.1`) → *MIT OR Apache-2.0*
- **log** (version: `0.4.30`) → *MIT OR Apache-2.0*
- **polonius-the-crab** (version: `0.5.0`) → *Zlib OR MIT OR Apache-2.0*
- **ringbuf** (version: `0.5.0`) → *MIT/Apache-2.0*
- **strum** (version: `0.28.0`) → *MIT*
- **chrono** (version: `0.4.44`) → *MIT OR Apache-2.0*
- **thiserror** (version: `2.0.18`) → *MIT OR Apache-2.0*
- **rand** (version: `0.10.1`) → *MIT OR Apache-2.0*
- **regex** (version: `1.12.3`) → *MIT OR Apache-2.0*
- **serde** (version: `1.0.228`) → *MIT OR Apache-2.0*

ringbuf is the odd one out.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions