Adding support for eslint 9#3244
Conversation
|
Giving it a try @ljharb 🙏 |
This comment was marked as resolved.
This comment was marked as resolved.
| "eslint": "^7.32.0 || ^8.2.0", | ||
| "eslint-find-rules": "^4.1.0", | ||
| "eslint": "^7.32.0 || ^8.2.0 || ^9.0.0", | ||
| "eslint-find-rules": "^5.0.0", |
There was a problem hiding this comment.
eslint-find-rules v5 doesn't support eslint 7, so this will have to be ^4.1.0 || ^5.0.0
| "dependencies": { | ||
| "confusing-browser-globals": "^1.0.11" | ||
| "confusing-browser-globals": "^1.0.11", | ||
| "globals": "^15.14.0" |
There was a problem hiding this comment.
why is globals needed? eslint ships with that package and we should be using the same version it uses.
There was a problem hiding this comment.
@ljharb without it being in the package.json we fail the no extraneous dependencies check due to the import. So I put it as a peer dependency. Otherwise I could either disable the rule or use the raw values instead of from globals. Let me know if you want a different change
| "eslint": "^7.32.0 || ^8.2.0", | ||
| "eslint-find-rules": "^4.1.0", | ||
| "eslint": "^7.32.0 || ^8.2.0 || ^9.0.0", | ||
| "eslint-find-rules": "^5.0.0", |
|
@ljharb let me know your thoughts with the changes |
|
@ljharb are the issues with the previous iteration resolved? |
j-castellanos
force-pushed
the
jc/eslint-9-support
branch
from
3d1cb85 to
700d1a5
Compare
daltino
left a comment
daltino
left a comment
There was a problem hiding this comment.
This PR adds support for ESLint 9 by updating the package version requirements, introducing a new flat.js configuration file for rule definitions, and adjusting associated test files for the new file. Implementation looks comprehensive and well-tested with no breaking changes identified. Looking good!
3 participants
Giving my attempt at eslint 9 support 😅