Fail fast on two silent-failure paths in the Java Pattern refactor en… - #161
Merged
Conversation
…gine JavaPatternASTOperation could previously produce silently incorrect output in two cases: - A @JavaPatternReplacement method body with more than one statement only ever used the first statement; any further statements were discarded with no warning. - If more than one @JavaPattern in a matcher file matched the same candidate AST node, JavaPatternASTOperation would attempt to rewrite that node twice against the single shared replacement template, which ASTRewrite is not designed to tolerate. Both cases now throw a clear exception instead. Added regression tests covering each case, plus a fixed-up CHANGELOG entry.
RadikalJin
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaPatternASTOperation could previously produce silently incorrect output in two cases:
Both cases now throw a clear exception instead. Added regression tests covering each case, plus a fixed-up CHANGELOG entry.