Add RedundantBooleanLiteralRefactor for Sonar rule java:S1125 - #162
Open
yashsiwacha wants to merge 1 commit into
Open
yashsiwacha wants to merge 1 commit into
yashsiwacha wants to merge 1 commit into
Conversation
Implement RedundantBooleanLiteralRefactor in astra-core to automatically identify and remove redundant boolean literal comparisons (e.g. "bool == true" -> "bool", "bool != false" -> "bool", "bool == false" -> "! bool"). Uses JDT type binding resolution to safely verify that the non-literal operand is indeed a boolean type (either primitive or boxed Boolean) before transforming, ensuring type safety and preventing changes on custom classes. Includes unit tests for all combinations of redundant comparisons (primitive and boxed types, reversed operand ordering, equals/not-equals operations), as well as positive/negative assertions. Closes S1125 Signed-off-by: Yash Siwach <yashsiwach07@gmail.com>
Member
|
Hi @yashsiwacha, and thank you for your contribution to Astra. The overall shape of this looks great, as are the tests with before/after examples - exactly the pattern we like to see. Before this can merge:
Everything else looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement RedundantBooleanLiteralRefactor in astra-core to automatically identify and remove redundant boolean literal comparisons (e.g. "bool == true" -> "bool", "bool != false" -> "bool", "bool == false" -> "! bool").
Uses JDT type binding resolution to safely verify that the non-literal operand is indeed a boolean type (either primitive or boxed Boolean) before transforming, ensuring type safety and preventing changes on custom classes.
Includes unit tests for all combinations of redundant comparisons (primitive and boxed types, reversed operand ordering, equals/not-equals operations), as well as positive/negative assertions.
Closes S1125