PostgreSQL 14 compatibility

[allentc]

Last year @philip-bonev did some work to allow PostgreSQL 14 compatibility. No pull request was offered. Should this work be incorporated into this repo?

The changes can be found here.

[proxy-m]

@allentc , Does it fully work with postgresql 14? I tested maximum only --with-pgsql=/usr/lib/postgresql/13

[allentc]

I don't know. I created the issue in the hope that anyone doing active development might test it and create a merge request.

[philip-bonev]

Hi,
I made the changes so I can use pgadmin3-lts easier. I have not tested with anything, but my current setup. I will try to do some tests with older versions of PostgreSQL.
Sphinx-build changes are related to the version in Pop!_Os/Ubuntu 21.04 and 21.10.

[SebDieBln]

I did use the current version in this fork with PostgreSQL 14 without issues (except the warning about the version when connecting), but I did not use all the features. Two questions:

• "Compatibility" means the current features of pgAdmin3 work with PostgreSQL 14? It does not mean having a GUI for features that might be new?
• What version of PostgreSQL do we assume to be fully compatible to at the moment? I could read the changelogs from that point on and check for changes that affect pgAdmin3.

[proxy-m]

Many people use dbeaver, pgadmin 4+ and dbvis dbvisualizer for new features of PostgreSQL. But I may be wrong.

[SebDieBln]

I just found an actual incompatibility:

A rather trivial query turned out to have this query plan and pgAdmin3 could not parse all elements. There was no crash, just question marks for the unknown elements and a warning/error when clicking on them.

Gather  (cost=1045.47..167870.86 rows=484043 width=3220)
  Workers Planned: 1
  ->  Nested Loop  (cost=45.47..118466.56 rows=284731 width=3220)
        ->  Parallel Bitmap Heap Scan on "TableFoo"  (cost=45.04..4866.92 rows=1464 width=3156)
              Recheck Cond: ("Foreign_ID" = ANY ('{1,2,3,4,6,7}'::integer[]))
              ->  Bitmap Index Scan on "I_TableFoo_Network_ID"  (cost=0.00..44.41 rows=2489 width=0)
                    Index Cond: ("Foreign_ID" = ANY ('{1,2,3,4,6,7}'::integer[]))
        ->  Index Scan using "I_TableBar_Section_ID" on "TableBar"  (cost=0.43..67.80 rows=980 width=68)
              Index Cond: ("Foo_ID" = "TableFoo"."Foo_ID")
JIT:
  Functions: 7
  Options: Inlining false, Optimization false, Expressions true, Deforming true

So it would seem there is still some work to do before pgAdmin3 is actually compatible with Postgres14.

[GreenReaper]

If you're looking to keep this going (and 15 will be coming along soon), it wouldn't hurt to let it run on the latest version, even if some features are not yet fully supported, as long as it doesn't cause data to be corrupted. The full list of changes seems to be short and seemingly backwards-compatibke (though I don't know if the Sphinx path need an ifdef or similar).