Repository navigation
Clean up temporary files after failed GCP cache downloads - #80
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Large-object GCP cache downloads write to a temporary file before
Blob.downloadTo. If the download fails, the cache service reports a miss but previously left the partial temporary file behind. This change deletes that file on failure while preserving the original exception; any cleanup exception is attached as suppressed.A synthetic unit test writes partial contents, throws an
IOException, and verifies the file is gone and the original exception is propagated.Validation
./gradlew jar check --no-daemon --stacktrace— passed (Gradle 9.7.1, JDK 17).GRADLE_CACHE_SERVICE_ACCOUNT_PATHwas unset. No real GCP credentials, buckets, metadata endpoint, or cloud operations were used.check.