fix(streaming): fire InputJsonEvent for server_tool_use blocks - #1875
Open
vjaudir8123-debug wants to merge 1 commit into
Open
fix(streaming): fire InputJsonEvent for server_tool_use blocks#1875vjaudir8123-debug wants to merge 1 commit into
vjaudir8123-debug wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When streaming a response that includes a
server_tool_useblock (e.g. computer use / bash tools), thebuild_eventsfunction was failing to yieldInputJsonEvents (andBetaInputJsonEvents) because it only checkedcontent_block.type == "tool_use".This meant users trying to stream the arguments of a server tool use would silently receive nothing, even though the JSON was being correctly accumulated in the background into the snapshot.
This PR adds
"server_tool_use"to the check, allowingInputJsonEventto fire correctly for server tools in both stable and beta streaming.