New Presplit utility for Fate table#6471
Open
ArbaazKhan1 wants to merge 2 commits into
Open
Conversation
DomGarguilo
requested changes
Jul 13, 2026
Comment on lines
+164
to
+165
| @Parameter(names = {"-n", "--numSplits"}, | ||
| description = "Generate N split points for the fate table and print to stdout. N should always be greater than 1.") |
Member
There was a problem hiding this comment.
Suggested change
| @Parameter(names = {"-n", "--numSplits"}, | |
| description = "Generate N split points for the fate table and print to stdout. N should always be greater than 1.") | |
| @Parameter(names = {"-n", "--num-splits"}, | |
| description = "Generate N split points for the fate table and print to stdout. N must be >= 1.") |
Comment on lines
+294
to
+295
| try (PrintWriter writer = new PrintWriter(new BufferedWriter( | ||
| new OutputStreamWriter(Files.newOutputStream(Path.of(options.splitsFile)), UTF_8)))) { |
Member
There was a problem hiding this comment.
I usually try not to nest constructors in a try-with-resources block. Usually things work out okay but putting each object constructed on its own line makes it more certain that each object will be cleaned up properly in the try-with-resources block as opposed to relying on the closure of the outmost object to cascade down and close the rest.
|
|
||
| @Parameter(names = {"-n", "--numSplits"}, | ||
| description = "Generate N split points for the fate table and print to stdout. N should always be greater than 1.") | ||
| int numSplits = 1; |
Member
There was a problem hiding this comment.
Suggested change
| int numSplits = 1; | |
| int numSplits = -1; |
I think we need to default to -1 here so that split generation is opt-in. If we leave it as 1, every fate invocation takes the numSplits > 0 branch and returns before normal commands like --print, --cancel, etc. can run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes issue #4979
Added support for pre-splitting Fate tables via accumulo admin command.
--numSplitsoption generates split points using the same partitioning logic as inFateManager.getDesiredPartitions. The logic ensures that pre-split boundires align with how the manger expects transaction IDs to be distributed. The split utility produces raw UUID row strings which should allow it be also be used by scan_ref.--splitsFileflag writes the generated splits to a file.