CASSJAVA-135 Update the build to use Java17 rather than Java8 - #2098
CASSJAVA-135 Update the build to use Java17 rather than Java8#2098absurdfarce wants to merge 2 commits into
Conversation
patch by Bret McGuire; reviewed by X and Y
|
Jenkins run on this new branch was also green (minus the PointIT issues which should be addressed by #2097) |
|
Ping @tolbertam for visibility after moving to a new PR |
SiyaoIsHiding
left a comment
SiyaoIsHiding
left a comment
There was a problem hiding this comment.
This will break ASF CI, right?
| 'openjdk@1.11', // OpenJDK version 11 | ||
| 'openjdk@1.17', // OpenJDK version 17 | ||
| 'openjdk@1.21', // OpenJDK version 21 | ||
| 'openjdk@21', // OpenJDK version 21 |
There was a problem hiding this comment.
We verified this change?
There was a problem hiding this comment.
Was 'openjdk@1.21' breaking?
There was a problem hiding this comment.
Yeah, "openjdk@1.21" wasn't working. The Jenkins runners use "jabba install openjdk@21" in their setup scripts and the difference is enough to throw things off.
I was seeing build failures caused by an inability to find Java when using "openjdk@1.21"... and those problems went away immediately when switching to "openjdk@21".
|
|
||
| mvn -B -V ${INTEGRATION_TESTS_FILTER_ARGUMENT} -T 1 verify \ | ||
| -Ptest-jdk-'''+testJavaVersion+''' \ | ||
| -DtestJavaHome='''+testJavaHome+''' \ |
There was a problem hiding this comment.
Why we don't need those profiles -Ptest-jdk-'''+testJavaVersion+''' anymore?
There was a problem hiding this comment.
Those profiles were put in place to implement a few extra CLI args that needed to be added for Java13 and up. Since we've moved our baseline up from Java8 to Java17 with this PR those configs apply in all cases now. So there's no reason to keep the profiles around; they'd all contain the same content, which would beg the question about why we didn't just roll them into a common config... which is what this PR does.
|
Hmmm, we might need to make some changes to the ASF CI to get it to build with Java17 as a default. But we probably need a general cleanup there anyway since I don't think the Java25 changes included any updates to the ASF Jenkinsfile either. Might be worth just having a general "update the ASF CI" PR once this goes in. |
|
What do I need to do locally to run |
|
Are you sure you switched to Java17 @SiyaoIsHiding? We switch to using the maven.compiler.release property in this PR since that's the standard way of notating this for "newer" JDKs (by which they apparently mean anything older than Java9). The error you're seeing seems to suggest that your javac version can't support "-release 17" which in turn makes me think you might still be using an older JDK. To validate I executed |
2 participants
Replaces #2096