CASSANDRA-21648: Handle error gracefully when client sends malformed IN-marker bytes (6.0) - #5112
Open
nivykani wants to merge 2 commits into
Open
CASSANDRA-21648: Handle error gracefully when client sends malformed IN-marker bytes (6.0)#5112nivykani wants to merge 2 commits into
nivykani wants to merge 2 commits into
Conversation
Contributor
|
See comments on #5111 (as I think they also apply here). Also, the base branch here should be |
Author
|
Thanks for catching that! Switched base branch and fixed comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the regression where 6.0 stopped gracefully handling malformed IN-marker bytes sent by clients. Compare to 5.0: https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/cql3/Lists.java#L227-L241
This causes an uninformative server-side error, instead of a more useful invalid-request error.
The Cassandra Jira