CASSANDRA-17350: Clarify stale on_fork() comments in copyutil.py - #5129
Open
arvindKandpal-ksolves wants to merge 1 commit into
Open
CASSANDRA-17350: Clarify stale on_fork() comments in copyutil.py#5129arvindKandpal-ksolves wants to merge 1 commit into
arvindKandpal-ksolves wants to merge 1 commit into
Conversation
Windows code was already removed in CASSANDRA-16956, but the comments were left as an open question. Channels/generators must still be created after fork, not in __init__ - a thread doesn't survive fork and isn't picklable on spawn platforms like macOS (CASSANDRA-11053, CASSANDRA-11701). Comment-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CASSANDRA-16956 removed the Windows-specific code here but left the
comments as an open question ("might be initialised directly here?").
Turns out moving this to init was never safe, Windows or not:
This just rewords the comments to explain the real reason. No behavior change, no tests affected (none exist for this code).
The Cassandra Jira