Skip to content

[CELEBORN-2419] Fix the warning: deprecated systemProperties parameter in maven-surefire-plugin - #3797

Closed
yew1eb wants to merge 1 commit into
apache:mainfrom
yew1eb:CELEBORN-2419
Closed

[CELEBORN-2419] Fix the warning: deprecated systemProperties parameter in maven-surefire-plugin#3797
yew1eb wants to merge 1 commit into
apache:mainfrom
yew1eb:CELEBORN-2419

Conversation

@yew1eb

@yew1eb yew1eb commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Replace deprecated <systemProperties> with <systemPropertyVariables> in maven-surefire-plugin configuration in root pom.xml.

Why are the changes needed?

Maven Surefire Plugin 3.0.0-M5+ deprecated the <systemProperties> parameter. Using it produces a warning on every build:

[INFO] --- surefire:3.0.0-M7:test (default-test) @ celeborn-client_2.12 ---
[WARNING]  Parameter 'systemProperties' is deprecated: Use systemPropertyVariables instead.
[INFO] Tests are skipped.
[INFO] 
[INFO] --- surefire:3.0.0-M7:test (test) @ celeborn-client_2.12 ---
[WARNING]  Parameter 'systemProperties' is deprecated: Use systemPropertyVariables instead.
[INFO] Tests are skipped.

Does this PR resolve a correctness bug?

  • Yes

Does this PR introduce any user-facing change?

  • Yes

How was this patch tested?

…ertyVariables> in surefire plugin configuration

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the root Maven build configuration to remove a Maven Surefire Plugin deprecation warning by switching to the supported configuration parameter for passing system properties to test JVMs.

Changes:

  • Replaced <systemProperties> with <systemPropertyVariables> in the maven-surefire-plugin configuration in the root pom.xml.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@SteNicholas SteNicholas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteNicholas

Copy link
Copy Markdown
Member

Thanks. Merged to main(v1.0.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants