[CELEBORN-2420] Bump scala version to 2.12.18 - #3799
Closed
yew1eb wants to merge 3 commits into
Closed
Conversation
Explicitly set empty maven.compiler.release property to prevent maven-compiler-plugin 3.12.1 from auto-deriving --release flag, which is not supported by Java 8's javac.
… error on JDK 8 Bump scala.version from 2.12.15 to 2.12.18 in spark-3.2 and spark-3.3 profiles. Scala 2.12.15 unconditionally rejects any -release value on JDK 8, but scala-maven-plugin 4.9.x auto-generates -release 8 from maven.compiler.target=8. Scala 2.12.18 allows -release 8 on JDK 8.
SteNicholas
approved these changes
Aug 14, 2026
SteNicholas
left a comment
SteNicholas
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for contribution.
Member
|
Merged to main(v1.0.0). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
scala.versionto 2.12.18 across all spark-3.x profiles.maven.plugin.silencer.versionoverride (1.6.0) from spark-3.0 and spark-3.1 profiles, so they use the default 1.7.19 which supports scala 2.12.18.Why are the changes needed?
scala-maven-plugin 4.9.x auto-generates
-release 8frommaven.compiler.target=8and passes it to scalac. Scala 2.12.10–2.12.17 all have issues with-releaseon JDK 8:-releaseon JDK 8-releaseoption, would fail with "bad option"Scala 2.12.18 allows
-release 8on JDK 8.Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
How was this patch tested?
./build/make-distribution.sh -Pspark-3.0on JDK 8../build/make-distribution.sh -Pspark-3.3on JDK 8.