vmware-base: fix template copy from secondary to primary

[weizhouapache]

Description

This PR fixes #7572 #12036 #12610 (hopefully)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested with vm template http://dl.openvm.eu/cloudstack/macchinina/x86_64/

Without this PR: filesystem error (90% possibility)

With this PR: all are good (100%)

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.33%. Comparing base (6136ac9) to head (6e75c5f).

Files with missing lines	Patch %	Lines
...om/cloud/hypervisor/vmware/util/VmwareContext.java	0.00%	56 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #13977   +/-   ##
=========================================
  Coverage     16.32%   16.33%           
- Complexity    13556    13562    +6     
=========================================
  Files          5669     5669           
  Lines        501399   501431   +32     
  Branches      60902    60902           
=========================================
+ Hits          81847    81893   +46     
+ Misses       410390   410371   -19     
- Partials       9162     9167    +5     

Flag	Coverage Δ
uitests	4.14% <ø> (ø)
unittests	17.19% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18991

[weizhouapache]

@blueorangutan test ol9 vmware-80u3

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-16833)

[blueorangutan]

[SF] Trillian Build Failed (tid-16845)

[blueorangutan]

[SF] Trillian test result (tid-16846)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 76722 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13977-t16846-vmware-80u3.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	Error	145.95	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	Error	62.40	test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster	Failure	44.16	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	Failure	0.09	test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity	Failure	182.45	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	Error	105.52	test_nonstrict_affinity_group.py
ContextSuite context=TestMigrateVMStrictTags>:setup	Error	0.00	test_vm_strict_host_tags.py
test_01_restore_vm_strict_tags_success	Error	3605.57	test_vm_strict_host_tags.py
test_02_restore_vm_strict_tags_failure	Error	9.03	test_vm_strict_host_tags.py
test_01_scale_vm_strict_tags_success	Error	18.05	test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure	Error	3604.19	test_vm_strict_host_tags.py
test_01_deploy_vm_on_specific_host_without_strict_tags	Error	17.07	test_vm_strict_host_tags.py
test_02_deploy_vm_on_any_host_without_strict_tags	Error	3605.73	test_vm_strict_host_tags.py
test_03_deploy_vm_on_specific_host_with_strict_tags_success	Error	3.89	test_vm_strict_host_tags.py
test_04_deploy_vm_on_any_host_with_strict_tags_success	Error	5.78	test_vm_strict_host_tags.py

[DaanHoogland]

some comments and test results don’t look too good. But that last bit is probably in the vmware test suite itself.

[weizhouapache]

thanks @DaanHoogland

the smoke tests results are consistent with the 4.23.0.0 RC3, I think there is no regression caused by it, we could run together with #13628

will update the PR as you suggested.

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19040

[weizhouapache]

@blueorangutan test ol8 vmware-80u3

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-16863)

[weizhouapache]

@blueorangutan test ol8 vmware-80u3

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests