remove deprecated APIs: RowIndex, raw_data, check_arrow_schema_type_compatible, try_new_with_having#23110
Open
NotFoundOvO wants to merge 1 commit into
Open
remove deprecated APIs: RowIndex, raw_data, check_arrow_schema_type_compatible, try_new_with_having#23110NotFoundOvO wants to merge 1 commit into
NotFoundOvO wants to merge 1 commit into
Conversation
Following the deprecation policy (6 major versions or 6 months), remove these APIs that were deprecated in 46.0.0-48.0.0: - RowIndex struct (46.0.0, dead code - file not even compiled) - ScalarValue::raw_data (46.0.0, no callers) - DFSchema::check_arrow_schema_type_compatible (47.0.0, no callers) - Filter::try_new_with_having (48.0.0, no callers) Closes apache#23080 (partial)
github-actions
Bot
added
logical-expr
Contributor
|
I think these may have been done already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #23080 (partial - removing 4 of the listed candidates)
What changes are included in this PR?
Removed the following deprecated APIs that are eligible for removal per the deprecation policy:
RowIndexstruct (deprecated 46.0.0) - dead code, the file wasn't even compiledScalarValue::raw_data(deprecated 46.0.0) - no callers, replaced byto_arrayDFSchema::check_arrow_schema_type_compatible(deprecated 47.0.0) - no callersFilter::try_new_with_having(deprecated 48.0.0) - no callers, replaced bytry_newAre these changes tested?
No new tests needed - these are pure removals of unused code with zero callers.
Are there any user-facing changes?
No. All removed APIs were already deprecated and had no internal callers.