chore(datasource): remove deprecated add_row_stats (Closes #23080 - partial)#23134
chore(datasource): remove deprecated add_row_stats (Closes #23080 - partial)#23134Dodothereal wants to merge 1 commit into
Conversation
`datafusion_datasource::add_row_stats` was deprecated in DataFusion 47.0.0 with the suggestion to use `Statistics::add`. Per the API health deprecation guidelines, APIs deprecated in 47.0.0 are eligible for removal now that datafusion is on 55.x. A repo-wide grep confirms zero callers of `add_row_stats` — the only non-test references are the deprecated function definition itself and a single `pub use statistics::add_row_stats;` re-export line in `datafusion/datasource/src/mod.rs` (with a comment explicitly noting 'Remove when add_row_stats is remove'). This commit removes both the function and the now-unneeded re-export/comment. Closes apache#23080 (partial — first in this batch to come from the 47.0.0-deprecated set).
|
Re-pinging: this PR is a 7-line removal of |
|
@alamb (and any other reviewer) — gentle ping: this is the 4th removal in the #23080 sweep; the first three (#23129, #23131, #23132) all landed today. Branch is up to date with upstream/main; commit |
thanks @Dodothereal -- we are working on it -- just never enough reviewer bandwidth unfortunately |
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
…loses apache#23080 - partial) (apache#23135) Removes Signature::get_possible_types (deprecated since 46.0.0 with replacement get_example_types). Pure 5-line deletion; the in-tree unit test already calls get_example_types directly, so no test updates needed. Closes apache#23080 (partial - fifth in housekeeping series after apache#23129, apache#23131, apache#23132, apache#23134). AI assistance: used an AI coding assistant; verified via repo-wide grep that the function is unused outside tests.
Removes datafusion_datasource::add_row_stats (deprecated since 47.0.0 with replacement Statistics::add). Zero callers — the only references are the deprecated function definition and a single pub use re-export (carrying an explicit 'Remove when add_row_stats is remove' comment, indicating this was already acknowledged as future work). Pure 11-line deletion across 2 files. Closes #23080 (partial - fourth in housekeeping series after #23129, #23131, #23132). AI assistance: used an AI coding assistant; verified via repo-wide grep that the function has no callers.