Skip to content

branch-4.0: [test](fe) Cover internal query audit failure in FE unit test #65696#65764

Merged
morningman merged 1 commit into
apache:branch-4.0from
yujun777:cherry-pick-pr-65696-4.0
Jul 23, 2026
Merged

branch-4.0: [test](fe) Cover internal query audit failure in FE unit test #65696#65764
morningman merged 1 commit into
apache:branch-4.0from
yujun777:cherry-pick-pr-65696-4.0

Conversation

@yujun777

Copy link
Copy Markdown
Contributor

cherry-pick: #65696

…#65696)

The previous regression coverage for internal query audit failures
depended on querying `__internal_schema.audit_log` after a
fault-injection failure. That path is timing-sensitive because audit
persistence is asynchronous, so the regression can fail even when
`StmtExecutor.executeInternalQuery()` already reports the error audit
event correctly.

This PR replaces that flaky coverage with a deterministic FE unit test.
The new test forces a planning failure in `executeInternalQuery()` and
verifies that the submitted `AuditEvent` is marked as `ERR` and carries
the failure details. The unstable fault-injection regression case is
removed.
@yujun777
yujun777 requested a review from morningman as a code owner July 17, 2026 08:41
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@yujun777

Copy link
Copy Markdown
Contributor Author

run cloud_p0

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jul 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 2cb3e65 into apache:branch-4.0 Jul 23, 2026
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants