[fix](datetime) preserve date/time v1 compatibility during rolling upgrade#65771
Open
jacktengg wants to merge 2 commits into
Open
[fix](datetime) preserve date/time v1 compatibility during rolling upgrade#65771jacktengg wants to merge 2 commits into
jacktengg wants to merge 2 commits into
Conversation
…grade Old FE plans can carry DATE, DATETIME, and legacy TIME types, while the new BE implementations default to V2 physical columns. This may produce a logical/physical type mismatch and crash downstream casts during a rolling upgrade. Dispatch now, curdate, utc_timestamp, makedate, and convert_tz according to the plan types. Normalize the removed thrift TIME value to TIMEV2, reject unsupported result types explicitly, and cover the legacy plan paths in unit tests.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #56807
Problem Summary:
Old FE plans can carry DATE, DATETIME, and legacy TIME types, while the new BE implementations default to V2 physical columns. This may produce a logical/physical type mismatch and crash downstream casts during a rolling upgrade.
Dispatch now, curdate, utc_timestamp, makedate, and convert_tz according to the plan types. Normalize the removed thrift TIME value to TIMEV2, reject unsupported result types explicitly, and cover the legacy plan paths in unit tests.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)