[ci][integrations] Enable Elasticsearch vector-store tests - #1011
Merged
wenjin272 merged 3 commits intoAug 14, 2026
Conversation
2 tasks
kaiwangleo
force-pushed
the
bug/issue-999-elasticsearch-filter
branch
from
August 14, 2026 06:26
e3f654c to
e2d30ef
Compare
Contributor
|
Thanks for taking this on. I have adjusted the PR title to reflect the current CI-focused scope. |
wenjin272
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #999
Root cause
Filtered
queryEmbeddingrequests applied the combined filter throughSearchRequest.postFilter(...)after Elasticsearch had already selected the unfiltered KNN top-k results. This could return fewer thankmatching documents.Fix
Apply the combined filter directly to the Elasticsearch KNN clause through
KnnSearch.Builder.filter(...).Existing unified
filters, rawfilter_queryhandling, AND composition,k,num_candidates, and exception behavior are preserved.Tests
filters;filter_query;